Unmerged trees

Tiago Vignatti vignatti at freedesktop.org
Tue May 18 13:47:15 PDT 2010


On 05/18/2010 11:21 PM, Keith Packard wrote:
> Do you have a suggestion as to who should review this? Ajax? We can prod
> an appropriate person, but I'd like to see it get a Reviewed-by: line
> before merging as it changes some scary internal bits.

I'd say ajax is a good candidate, yeah (though I poked him already and 
haven't seen any reply). But maybe you could point any special thinking 
for the "scary internal bits" you mentioned?

BTW, I have more patches queued already for our xfree86 DDX bus mess. 
Unfortunately this kind of patches are always very difficult to attract 
reviewers and contributors (e.g. lrmi-for-children branches I have there 
carrying for months). I'm afraid we should come with other great idea 
soon how to deal with those, otherwise this part of the server will 
always going to be jurrasic and developing very slowly [0].


> The last patch in that sequence isn't marked with a Reviewed-by: yet;
> I've looked it over and if Peter hasn't reviewed it, you can add:
>
> Reviewed-by: Keith Packard<keithp at keithp.com>

my fault. Peter has reviewed and I mistakenly forgot to put his stamp 
there. I can rebase locally or maybe you can amend Peter's there and 
push yourself :)


Thanks,

[0] Xorg <-> linux mapping would helps :) /me runs...

             Tiago


More information about the xorg-devel mailing list