[PATCH] dix: Reshuffle ScreenRec to pack holes

Keith Packard keithp at keithp.com
Wed May 19 16:27:59 PDT 2010


On Wed, 19 May 2010 17:58:15 -0400, Adam Jackson <ajax at nwnk.net> wrote:
> On Wed, 2010-05-19 at 16:04 -0400, Adam Jackson wrote:
> 
> > I dunno, the whole blackPixel/whitePixel thing is an anachronism.  The
> > idea is that on monochrome framebuffers it's not especially obvious
> > whether 1 or 0 is black.  But, anymore, I really can't justify giving a
> > damn.  0 is black, move on.
> 
> Actually, it's not this.  whitePixel and blackPixel in the ScreenRec are
> the colormap slots with the pre-allocated white and black pixel values
> in them.  I'm fine with hardcoding that.  I'm tempted to _also_ remove
> -flipPixels from the xfree86 DDX, which cheats those two around so that
> the _values_ in those slots map to the other color.

They're used on anything which isn't TrueColor. But, it is just a pixel
value, and so can be CARD32.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100519/3d5f8584/attachment.pgp>


More information about the xorg-devel mailing list