[PATCH 1/2] glxdriswrast: Use CreateGC, not CreateScratchGC.

[Keith Packard]

On Wed, 19 May 2010 15:25:43 -0700, Jamey Sharp <jamey at minilop.net> wrote:
> Since this code was using CreateScratchGC and not GetScratchGC,
> FreeScratchGC would always call FreeGC, so just call it directly.

I'm having a hard time caring; drivers don't call CreateGC either, so it
seems like we can pick one of these to export.

In fact, we could export only CreateScratchGC and FreeScratchGC, making
it impossible for driver writers to call FreeGC after calling GetScratchGC.

> As long as the drawable provided to CreateGC has the same screen and
> depth as were passed to CreateScratchGC, these functions are basically
> identical. There are two differences:

One would think that graphicsExposures should be set to FALSE for
scratch GCs as well, but they aren't. Very strange.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100519/f6148ce7/attachment.pgp>