[PATCH 3/5 v4] Show Xserver release/version date in DIX & DDX docs

[Dan Nicholson]

On Wed, May 19, 2010 at 12:23 PM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
>> Date: Wed, 19 May 2010 09:56:29 -0700
>> From: Alan Coopersmith <alan.coopersmith at oracle.com>
>>
>> Mark Kettenis wrote:
>> >> From: Alan Coopersmith <alan.coopersmith at oracle.com>
>> >> Dan Nicholson wrote:
>> >>> On Tue, May 18, 2010 at 3:51 PM, Alan Coopersmith
>> >>>> +       (cd $(XML_ENT_DIR) && $(MAKE) $(AM_MAKEFLAGS) $(@F))
>> >>> Is $(@F) a gnu makeism? I can't tell, but I don't think so.
>> >> I first learned about it when using Solaris make, and since it also worked
>> >> with GNU make, I assumed it was fairly common but didn't check, since GNU
>> >> make is currently required to build the Xorg server due to the "sinclude"
>> >> usage in the exported interfaces list generation in the module loader.
>> >
>> > That is unfortunate.  On OpenBSD we do build Xorg with our own (BSD)
>> > make.  Please try to avoid using GNU-isms.
>>
>> You're preaching to the choir here.  I try to build as much as
>> possible with Solaris make, and often have to fix the GNU-make-ism's
>> that don't get caught in review, but I've never taken the time to
>> work out a portable solution to the sdksyms/sinclude stuff in
>> hw/xfree86/loader/Makefile.am - are you actually building current
>> Xorg head (or a release since 1.7) with OpenBSD make?  If so, then I
>> guess OpenBSD must have adopted that GNU-ism.
>
> Ah, you're right.  It's implemented in our make, but not mentioned in
> the man page (probably intentionally to discourage people from using
> it).

That's what got me worried initially. I found some online doc for BSD
make that didn't mention that construct. However, the GNU make manual
is usually pretty clear when there's some feature that's not portable.

--
Dan