[PATCH 01/11] xfree86: Iterate tags attributes array correctly

[Dan Nicholson]

On Thu, May 20, 2010 at 9:25 AM, Jamey Sharp <jamey at minilop.net> wrote:
> That looks like an important bugfix for the matchers. It'd mean, what,
> only a suffix of the first tag on a device could match? I'd have liked
> to see a note in the commit message about how you can test for this
> bug; among other things that would make it easier to decide if this
> looks like a correct fix.

Yeah, sorry just noticed this morning while I was rebasing patch 6,
which had changed it to do the right thing inadvertently. It means
that if the backend has attached multiple tags (ID_INPUT.tags="foo
bar" for udev), only the first one would be matched. Also, a more
subtle bug would be that you get kind of substring matching of the
tag: MatchTag "foobar" would match ID_INPUT.tags="bar" whereas we're
advertising strcmp comparison.

> Assuming I've interpreted this correctly,
> Reviewed-by: Jamey Sharp <jamey at minilop.net>

I'll update the commit message with something useful and repost.

--
Dan