[PATCH 1/2] glxdriswrast: Use CreateGC, not CreateScratchGC.

Jamey Sharp jamey at minilop.net
Thu May 20 11:01:39 PDT 2010


On Wed, May 19, 2010 at 4:40 PM, Keith Packard <keithp at keithp.com> wrote:
> I'm having a hard time caring ...

Here's a stronger argument in favor of this patch: These two GCs
clearly aren't "scratch". They have the same lifetime as the GLX
drawable they're attached to. If this code switched from
CreateScratchGC to GetScratchGC, it would be holding the only scratch
GC of that depth for an arbitrarily long time. It should just be using
CreateGC, and then we should stop exporting CreateScratchGC as that's
never the right API to use.

Yes/no?

Jamey


More information about the xorg-devel mailing list