[PATCH] dix: Remove a large pile of backing store leftovers

Daniel Stone daniel at fooishbar.org
Thu May 20 13:43:34 PDT 2010


On Wed, May 19, 2010 at 12:37:34PM -0700, Keith Packard wrote:
> Because no-one loves rootless. I believe your analysis is correct; the
> 'exposed' region is being abused here to temporarily hold the region to
> be saved. I'll bet I did that to 'optimize' region usage in the original
> mi validate tree code -- 'exposed' is purely a temp variable, passed
> around to avoid re-initializing a region over and over. That should be
> fixed, and the leak of 'exposed' in the rootless code should be fixed as
> well.
> 
> So much bad code, so little time.
> 
> Let me know how much you're willing to clean this stuff up, I'll review
> whatever you manage to change.

I'll try to review this and reconcile it with the miValidateTree changes
I did for the N900 on the plane this weekend; feel free to kick me if I
haven't next week.

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100521/d9f6f060/attachment.pgp>


More information about the xorg-devel mailing list