[PATCH 2/4] Rename region macros to mixed case and remove screen argument

Jamey Sharp jamey at minilop.net
Fri May 21 15:12:47 PDT 2010


I get different results from running fix-region than are reflected in
this patch. I think the script is giving the right output, and the
patch is wrong in places.
- doc/xml/Xserver-spec.xml incorrectly dropped the pScreen argument
from BitmapToRegion.
- The patch misses some REGION_BREAK uses.
- Most of the RegionDestroy calls wound up with a space after the open-paren.

It's kind of confusing having some functions, like RegionInit, get
disabled with #ifndef in this patch. I know the next commit cleans
that up, but since you don't use the code from the function
implementations at all in that later patch, can I suggest just
deleting them in this one?

This hardly should block merge, but would you consider fixing the `git
diff --check` whitespace warnings in this patch? None of them were
introduced here (except in the sed script) but it'd be nice to fix
them as long as you're touching these lines anyway.

Jamey


More information about the xorg-devel mailing list