[PATCHv2] dix: add 3x3 transformation matrix xinput property for multi-head handling

[Peter Korsgaard]

>>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:

Hi,

 >> /**
 >> * DIX property handler.
 >> */
 >> @@ -115,6 +158,14 @@ DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop,
 >> else if (!(*((CARD8*)prop->data)) && dev->enabled)
 >> DisableDevice(dev, TRUE);
 >> }
 >> +    } else if (property == XIGetKnownProperty(XI_PROP_TRANSFORM))
 >> +    {
 >> +        if (prop->format != 32 || prop->size != 9 ||
 >> +            prop->type != XIGetKnownProperty(XATOM_FLOAT))
 >> +            return BadValue;
 >> +
 >> +        if (!checkonly)
 >> +            DeviceSetTransform(dev, prop->data);
 >> }

 Peter> are we going to allow values > 1? If not, there should be BadValue checks
 Peter> here.


Sorry, values? I don't follow - As far as I can see I verify every
member of XIPropertyValuePtr?


 >> +static void
 >> +TransformAbsolute(DeviceIntPtr dev, int v[MAX_VALUATORS])

 Peter> minor nitpick, the other static ones have lowercase first letters, so
 Peter> transformAbsolute is preferable here.


Ok, will fix and resend.

-- 
Bye, Peter Korsgaard