[PATCHv2] dix: add 3x3 transformation matrix xinput property for multi-head handling

Peter Korsgaard jacmet at sunsite.dk
Sun May 23 23:20:42 PDT 2010


>>>>> "Peter" == Peter Hutterer <peter.hutterer at who-t.net> writes:

Hi,

 >> Sorry, values? I don't follow - As far as I can see I verify every
 >> member of XIPropertyValuePtr?

 Peter> except prop->data, right? so if that contains values > 1, wouldn't that mess
 Peter> things up? If so, we need something like

 Peter> float *data = prop->data;
 Peter> for (i = 0; i < prop->size; i++)
 Peter>  $if (data[i] < 0 || data[i] > 1)
 Peter>     return BadValue;

Ahh, the actual matrix elements? I don't right away see any need for
values over 1, but you do need negative values when using rotation.

Perhaps >1 values are interesting if you want an absolue input device to
span multiple screens for some kind of video wall with touchscreen
setup?

All in all, I would prefer to not hardcode any policy here in the
server. Strange values doesn't really harm us.

-- 
Bye, Peter Korsgaard


More information about the xorg-devel mailing list