[PATCH] midispcur: Construct Picture objects lazily in case Render is disabled.

Jamey Sharp jamey at minilop.net
Mon May 24 19:05:24 PDT 2010


On Mon, May 24, 2010 at 4:49 PM, Pierre-Loup A. Griffais
<pgriffais at nvidia.com> wrote:
> On 05/24/2010 09:34 AM, Jamey Sharp wrote:
>> These Pictures are not freed in miDCDeviceCleanup. Before the "don't
>> thrash resources" patch, there was a comment suggesting that
>> pRootPicture was already freed for some reason, but it did free
>> pTempPicture.
>
> See http://lists.x.org/archives/xorg-devel/2010-April/007699.html

Ah, I get it. Thanks for the pointer; I've just sent a patch that
includes a comment explaining what's going on there.

> The patch itself looks good to me.

Would you provide a "Reviewed-by" tag, and CC Keith, then?

Thanks!
Jamey


More information about the xorg-devel mailing list