[PATCH 02/16] xf86AutoConfig: Simplify builtin-config splitting.

Mark Kettenis mark.kettenis at xs4all.nl
Wed May 26 12:12:42 PDT 2010


> From: Jamey Sharp <jamey at minilop.net>
> Date: Wed, 26 May 2010 10:40:51 -0700
> 
> On Wed, May 26, 2010 at 1:29 AM, Mark Kettenis <mark.kettenis at xs4all.nl> wrote:
> >> From: Jamey Sharp <jamey at minilop.net>
> >> Date: Tue, 25 May 2010 16:53:13 -0700
> >>
> >> @@ -179,7 +169,7 @@ xf86AutoConfig(void)
> >>      xf86MsgVerb(X_DEFAULT, 3, "--- End of built-in configuration ---\n");
> >>
> >>      xf86initConfigFiles();
> >> -    xf86setBuiltinConfig(builtinConfig);
> >> +    xf86setBuiltinConfig((const char **) builtinConfig);
> >
> > That cast isn't really necessary isn't it?
> 
> I wasn't happy about it either, but at least according to GCC, while
> "const char *" is assignment-compatible from "char *", "const char **"
> is not compatible with "char **". So I was going to have to cast
> either at the call to free or this call to xf86setBuiltinConfig, and
> this seemed more sane to me.

Ugh, pointers to pointers continue to confuse me, so I wouldn't be
able to tell if GCC is on crack here or not.  Thanks for the
explanation.


More information about the xorg-devel mailing list