[PATCH] xfree86: Unbreak autoconfig following 0abf065e38c4
Vignatti Tiago (Nokia-D/Helsinki)
tiago.vignatti at nokia.com
Thu May 27 05:00:29 PDT 2010
Hi Chris,
On Wed, May 26, 2010 at 09:44:51PM +0200, ext Chris Wilson wrote:
> The move of the PCI device id probing into a separate file neglected to
> return the number of found devices, and so the PCI devices were being
> overwritten by the default entries for vesa and fbdev.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Tiago Vignatti <tiago.vignatti at nokia.com>
We also can add a short description here. Something like:
/*
* @return The numbers of found devices that match with the current system
* drivers.
*/
Can you amend this, please?
> -void
> +int
> xf86PciMatchDriver(char* matches[], int nmatches) {
> int i;
> struct pci_device * info = NULL;
> @@ -1326,4 +1326,6 @@ xf86PciMatchDriver(char* matches[], int nmatches) {
> if ((info != NULL) && (i < nmatches)) {
> i += videoPtrToDriverList(info, &(matches[i]), nmatches - i);
> }
> +
> + return i;
> }
Thanks,
Tiago
More information about the xorg-devel
mailing list