[PATCH v5 0/4] Allow compiling dri2 without libdrm

Kristian Høgsberg krh at bitplanet.net
Fri May 28 17:13:56 PDT 2010


On Fri, May 28, 2010 at 12:13 PM, Pauli Nieminen
<ext-pauli.nieminen at nokia.com> wrote:
> These patches make it possible to use dri2 without libdrm. Dropping
> libdrm support is done as optional compile time option to keep ABI/API
> compability with older libdrm based drivers.
>
> In future libdrm could be dropped from xserver because libdrm should be
> driver side implementation detail.
>
> I rebased these patches to the latest xserver master. That includes
> removal of malloc wrappers.

The entire series is fine, but the order of the first three patches is
a little odd. The first patch will let us compile the X server without
linking to libdrm while still using the libdrm functions
unconditionally in dri2.c.  To be honest, I think just squashing the
first three patches into one makes sense, or at least apply the patch
to add the auth hook first and then squash the two patches that
provide the configure option and adds the #ifdef lines in dri2.c.

Kristian


More information about the xorg-devel mailing list