[PATCH 5/6] xfree86: fbdevhw: remove secondary way to find fb PCI device

Vignatti Tiago (Nokia-D/Helsinki) tiago.vignatti at nokia.com
Mon May 31 07:48:56 PDT 2010


On Mon, May 31, 2010 at 04:36:51PM +0200, ext Michel Dänzer wrote:
> On Mon, 2010-05-31 at 17:10 +0300, Vignatti Tiago (Nokia-D/Helsinki)
> wrote: 
> > On Mon, May 31, 2010 at 03:58:46PM +0200, ext Michel Dänzer wrote:
> > > On Mon, 2010-05-31 at 16:16 +0300, Tiago Vignatti wrote: 
> > > > fbdevhw already relies in libpciaccess, which in turn relies in sysfs to probe
> > > > devices. If sysfs is reporting wrong values then we're doomed anyway. So we
> > > > totally rely on sys and this second suspicious way to match fb <-> PCI becomes
> > > > superfluous.
> > > 
> > > So the /sys/bus/pci/devices/%04x:%02x:%02x.%d/graphics/fb%d /
> > > /sys/bus/pci/devices/%04x:%02x:%02x.%d/graphics:fb%d files were already
> > > there in the minimum Linux kernel version required by libpciaccess?
> > 
> > I don't know the answer, but why you care?
> 
> Because otherwise this change will break at least the fbdev driver on
> some systems.

How it will break? I though I was pretty clear regarding the commit message
saying that we have to trust on sysfs otherwise we're doomed. When I mentioned
libpciaccess there was just to mention that we are already relying on sysfs
for other purposes.

I'm afraid I'm still not getting your point Michel :/ 

             Tiago


More information about the xorg-devel mailing list