[PATCH 5/6] xfree86: fbdevhw: remove secondary way to find fb PCI device

[Michel Dänzer]

On Mon, 2010-05-31 at 18:21 +0300, Vignatti Tiago (Nokia-D/Helsinki)
wrote: 
> On Mon, May 31, 2010 at 05:03:56PM +0200, ext Michel Dänzer wrote:
> > 
> > sysfs didn't appear in its current form instantly but in evolutionary
> > steps. AFAIR the files above (which with your change are required for
> > the matching to work) were added relatively recently, and it might be
> > possible for libpciaccess to otherwise work fine with kernels which
> > didn't have them. Now I may well be wrong about this, but it would be
> > nice if you could check rather than asserting the code is 'superfluous'.
> 
> Ah, okay. Now I understood what you're saying. 
> 
> X server's commit 46f55f5d, dating Jun 2006, introduced the code to use the
> interface /sys/bus/pci/devices/*/graphics:fb*. So I'd presume sysfs was
> working since that time and that we're safe enough to remove this secondary  
> way to match PCI devices (the actual changes introduced by my patch). 

That doesn't address the question above. (Actually I'd rather say the
comment added by it seems to confirm my suspicion, as it refers to these
files as 'the more modern way'.


> Therefore, if no one loudly scream now and if it's fine for you I'll keep my
> patch as it is (in the worst case should be pretty easy to create a hook for
> this on Pci.c though). Okay? 

No. As you're still not sure that the code is really superfluous, I'd
suggest leaving it in.


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer