[PATCH util-macros 1/2] Don't disable strict aliasing (-fno-strict-aliasing) globally

Gaetan Nadon memsize at videotron.ca
Tue Nov 2 05:23:39 PDT 2010


On Mon, 2010-11-01 at 16:34 -0700, Jeremy Huddleston wrote:

> So... basically what I said originally... ? ;)
> 

End result is the same. I failed to recognize this  level of
indirection:


        XORG_CWARNFLAGS would be updated to call these two and set 
        CWARNFLAGS="$(CFLAGS_WARNINGS) $(CFLAGS_NO_STRICT_ALIASING)"


This has nice advantages, and will help with the conversion so as long
as
XORG_CWARNFLAGS is set back to it's original value eventually. The
reason is that somewhere
in the future, either CFLAGS_WARNINGS or CFLAGS_NO_STRICT_ALIASING could
get changed.
This would unfortunately change the value of XORG_CWARNFLAGS still used
in previous versions
of modules or in modules outside the X.Org "in the wild".

By not touching XORG_CWARNFLAGS at all, we eliminate any risk, not to
mention possible confusion.

Once this point is settled, a patch can be submitted for review, along
with a plan for converting modules.

Thanks!

Gaetan


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101102/073ea456/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101102/073ea456/attachment.pgp>


More information about the xorg-devel mailing list