[PATCH] build.sh: allow tarballs with --modfile

[Simon Braunschmidt]

On 11/03/2010 05:11 AM, Trevor Woerner wrote:
> For some reason I missed Simon's patch (and it's not showing up in
> patchwork), could either of you send it to me?
> There's no reason to wait for me, if there's a bug there's a bug :-D
> I too have never tried building tarballs with build.sh, is it
> suggested on the wiki?
@Trevor: I just sent you a copy
> There are probably other paths in build.sh which don't support
> tarballs correctly :-)
Tarballs are at least mentioned on the wiki, though with the suggestion 
to use build-from-tarballs.sh. If there are more problems I am probably 
going to find them.

We are cross-building xorg in a kind of managed chroot environment and 
decided to go with the build-scripts provided in util/modular, but not 
to use the jhbuild approach, if possible.

This way we expect to benefit from the xorg build maintainer upstream 
knowledge with neighter having to learn and maintain jhbuild nor rolling 
our own flavour.

>
> A long time ago I started a thread wondering if the checkfortars()
> function was obsolete, which I guess was another way of saying:
> "should build.sh support building from tars?". No consensus was
> reached
>
> http://lists.x.org/archives/xorg-devel/2010-September/013134.html
I have read that discussion, it diverted rather quickly into the 
autotools topic...

I would rather suggest to get rid of/obsolete build-from-tarballs.sh and
manage it all from build.sh.

Judging from the git history build-from-tarballs.sh has often played 
catch-up to integrate changes from build.sh and still misses some 
details, eg "Automate build.sh a little more from FreeBSD (b531d24d)" 
and possibly others. In the end it is just a replication of the 
functionality in build.sh and thus replication of code.

Would patches to integrate all of build-from-tarballs.sh into build.sh 
with the purpose to remove build-form-tarballs.sh be accepted?

One possible candidate would be "Bug #6337: eval the configure line to 
preserve quoting" (8820a075), though I did not manage to find the 
corresponding bugtracker...

Cc to xorg-devel at lists.x.org

Regards, Gruessle
Simon Braunschmidt

>
> On Tue, Nov 2, 2010 at 5:53 PM, Gaetan Nadon<memsize at videotron.ca>  wrote:
>> On Tue, 2010-11-02 at 13:39 +0100, Simon Braunschmidt wrote:
>>
>> This change allows to build from tarballs when using the new --modfile
>> user-supplied sub-projects feature. Without this change, using tarballs
>> was not possible with --modfile
>>
>> It's a nice way of saying "it's a bug" :-)
>>
>> Let's give Trevor a couple of days to respond, else ping me to push the
>> patch.
>> I never tried to build tarballs with this script, I thought the
>> "build-from-tarballs.sh" script
>> was used for that.