[PATCH] build.sh: verbose error output for missing components

[Gaetan Nadon]

On Wed, 2010-11-03 at 14:47 +0100, Simon Braunschmidt wrote:

> Instead of Trevor Woerners proposal to automagically clone missing
> components,
> 

I originally made the suggestion, but you convinced me.

> http://lists.x.org/archives/xorg-devel/2010-November/014883.html
> 
> I would rather want to inform the user more verbosely
> about missing components and how to obtain them.
> 
> This could avoid situations where the user calls the build.sh script
> from the wrong location, and build.sh subsequently littering the users
> machine with unwanted git repositories in the wrong place.

Good point.

> 
> One such situation would be calling "somedir/build.sh L" instead of
> "somedir/build.sh -L", starting a build in the current directory
> for PREFIX "L" instead of listing the missing components (with the
> users intention having been to just list the components in build order).
> 
> Signed-off-by: Simon Braunschmidt <sbraun at emlix.com>
> ---
>  build.sh |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/build.sh b/build.sh
> index 207ff2b..0afbe50 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -1155,9 +1155,14 @@ date
>  if [ X"$nonexistent_components" != X ]; then
>      echo ""
>      echo "***** Skipped components (not available) *****"
> +	echo "Could neighter find a git repository (at the <module/component> paths)"
> +	echo "or a tarball (at the <module/> paths or ./) for:"
> +	echo "    <module/component>"
>      for mod in $nonexistent_components; do
>  	echo "    $mod"
>      done
> +    echo "You may want to provide the --clone option to build.sh"
> +    echo "to automatically git-clone the missing components"
>      echo ""
>  fi
>  


Acked-by: Gaetan Nadon <memsize at videotron.ca>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101103/686d2194/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101103/686d2194/attachment.pgp>