displayid: dubious assignments

Adam Jackson ajax at redhat.com
Mon Nov 8 13:30:34 PST 2010


On Sat, 2010-10-30 at 21:03 +0200, Nicolas Kaiser wrote:
> Hi there!
> 
> I noticed two assignments that look a bit peculiar to me.
> n is assigned MAX_HSYNC and MAX_VREFRESH, but these values
> get either overwritten or remain unused.
> I hope that's not a problem?

Well, it's not a problem at the moment, since the DisplayID code isn't
hooked up to anything.

Effectively the code is ignoring sync specifiers beyond
MAX_{HSYNC,VREFRESH} because the xf86MonPtr we're storing them into only
has that many slots.  Which is a bit lame in theory?  But even in EDID I
don't think I've _ever_ seen a monitor that specifies more than one sync
range, so it's a bit of a theoretical concern.

- ajax



More information about the xorg-devel mailing list