[PATCH x11proto] Add XF86XK_TouchpadOn/Off

Chris Bagwell chris at cnpbagwell.com
Mon Nov 8 19:17:23 PST 2010


On Mon, Nov 8, 2010 at 4:37 PM, Bastien Nocera <hadess at hadess.net> wrote:
> On Mon, 2010-11-08 at 16:32 -0600, Chris Bagwell wrote:
>> On Sun, Nov 7, 2010 at 11:24 PM, Peter Hutterer
>> <peter.hutterer at who-t.net> wrote:
>> > Patch is fine with me. any NAKs?
>> >
>> > The udev patch to standardise the behaviour is already in, see
>> > http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=a1ca5f60e0770299c5c5f21bd371f5823802412b
>> > It requires an update to xkeyboard-config as well, synchronised with udev to
>> > maintain consistency. That's possible once this change is in.
>> >
>>
>> And just to stress, at this point we need a commit made somewhere.
>> Might as well make this one.
>>
>> udev submission above has changed existing F22 values to F21 so at
>> minimum to align with them we need to update below value from
>> xkeyboard-config's inet + synchronized udev release to prevent
>> breakage of existing feature.
>
> Except that it never actually worked properly, so you wouldn't be
> breaking that much.
>

Yep.  I'm not trying to stress the broken part but the mismatch part.

I was motivated by your work and I'm working to get eee pc's working.
In their ACPI driver (eeepc-laptop or eeepc-wmi) they map a hotkey
meant for touchpad toggle to F13 (mapped before udev).  Its been this
way for quite a while and so not to useful out of the box.

I want to get that aligned to F21 or F22 or what ever people agree to
so it can benefit from the nice work you guys did in this area.

It makes sense for me to wait until both udev and xkeyboard-config
match before proceeding though.

Chris


More information about the xorg-devel mailing list