[PATCH x11proto] Add XF86XK_TouchpadOn/Off

Bastien Nocera hadess at hadess.net
Tue Nov 9 03:26:37 PST 2010


On Mon, 2010-11-08 at 22:26 -0600, Chris Bagwell wrote:
> On Mon, Nov 8, 2010 at 9:42 PM, Bastien Nocera <hadess at hadess.net> wrote:
> > On Mon, 2010-11-08 at 21:17 -0600, Chris Bagwell wrote:
> >> On Mon, Nov 8, 2010 at 4:37 PM, Bastien Nocera <hadess at hadess.net> wrote:
> >> > On Mon, 2010-11-08 at 16:32 -0600, Chris Bagwell wrote:
> >> >> On Sun, Nov 7, 2010 at 11:24 PM, Peter Hutterer
> >> >> <peter.hutterer at who-t.net> wrote:
> >> >> > Patch is fine with me. any NAKs?
> >> >> >
> >> >> > The udev patch to standardise the behaviour is already in, see
> >> >> > http://git.kernel.org/?p=linux/hotplug/udev.git;a=commit;h=a1ca5f60e0770299c5c5f21bd371f5823802412b
> >> >> > It requires an update to xkeyboard-config as well, synchronised with udev to
> >> >> > maintain consistency. That's possible once this change is in.
> >> >> >
> >> >>
> >> >> And just to stress, at this point we need a commit made somewhere.
> >> >> Might as well make this one.
> >> >>
> >> >> udev submission above has changed existing F22 values to F21 so at
> >> >> minimum to align with them we need to update below value from
> >> >> xkeyboard-config's inet + synchronized udev release to prevent
> >> >> breakage of existing feature.
> >> >
> >> > Except that it never actually worked properly, so you wouldn't be
> >> > breaking that much.
> >> >
> >>
> >> Yep.  I'm not trying to stress the broken part but the mismatch part.
> >>
> >> I was motivated by your work and I'm working to get eee pc's working.
> >> In their ACPI driver (eeepc-laptop or eeepc-wmi) they map a hotkey
> >> meant for touchpad toggle to F13 (mapped before udev).  Its been this
> >> way for quite a while and so not to useful out of the box.
> >>
> >> I want to get that aligned to F21 or F22 or what ever people agree to
> >> so it can benefit from the nice work you guys did in this area.
> >
> > Then no. You want to use the keys I'm trying to get added in the kernel:
> > http://thread.gmane.org/gmane.linux.kernel.input/16320
> >
> > Then map from those keys to the fXX function keys in udev. My guess
> > from:
> >  151         { KE_KEY, 0x37, { KEY_F13 } }, /* Disable Touchpad */
> >  152         { KE_KEY, 0x38, { KEY_F14 } },
> > is that one disables the key in hardware, and the other enables it,
> > right?
> >
> > Then it would be F22 and F23 respectively. So a popup is shown, but
> > gnome-settings-daemon doesn't actually change the state of the driver in
> > software.
> >
> 
> Its a real toggle indication on eee pc's and HW doesn't disable
> anything.  If I edit kernel today (Fedora 14) to send F22 instead of
> F13 then I get a nice popup and disable/enable of touchpad threw
> software.  I guess if I understood udev better I could have done above
> instead of recompiling kernel.
> 
> It looks like a done deal to get KEY_TOUCHPAD_TOGGLE patch in input.h
> so technically I need to make both a kernel update and then a udev
> update to map KEY_TOUCHPAD_TOOGLE to F2x.

Then KEY_TOUCHPAD_TOGGLE looks like it.

> Either way, it sounds like udev should change for eee pc's.  I'll need
> your or someones help to point me towards a udev mailing list when
> that time comes.

See the patch attached to:
http://thread.gmane.org/gmane.linux.kernel.input/16252
for an example.

The list is linux-hotplug on kernel.org

Cheers



More information about the xorg-devel mailing list