[PATCH hyperpen] Fixed indentation, dropped trailing whitespaces

Peter Hutterer peter.hutterer at who-t.net
Thu Nov 11 13:08:29 PST 2010


On Thu, Nov 11, 2010 at 04:35:06PM +0100, Manuel Reimer wrote:
> Peter Hutterer wrote:
> >You know that working on hyperpen automatically makes you the maintainer of
> >the driver? Now's the time to run away screaming :)
> 
> So far, I'm not sure, if I will have the time to do bigger changes.
> 
> I think what would have to be done is:
> - Separate source code into a .c and a .h file, to make the .c easier to understand
> - Port over some good ideas from apitek and wacom drivers
> - Make it possible to define two input devices in xorg.conf (one for
> puck, one for stylus) both sharing the same physical device

the best way to go about these drivers is to get them handled properly by
the kernel and then hook the evdev or wacom driver onto them from
userspace. (I acknowledge the Linux bias here)
trying to port features over will just result in code duplication and a lot
of maintenance time for little benefit. Have you looked at a hyperpen kernel
driver at all?

> >the patch itself is corrupt, possibly some linewrapping issue. can you send
> >it again as attachment please? Thanks.
> 
> Did so with this posting/mail. I access this mailing list via gmane.
> Don't use mail at all. I copied the patch over via copy&paste into
> my newsreader. Maybe this is the reason why it got corrupted. I
> think I have to find a better configuration for my future commits.

Thanks, applied the patch locally. It doesn't build just yet because of the
ABI 12 changes, I'll fix that up and push asap.

Cheers,
  Peter


More information about the xorg-devel mailing list