[RFC XI 2.1 - xserver 6/9] Make EventIsDeliverable non-static

Cyril Brulebois kibi at debian.org
Fri Nov 12 19:13:50 PST 2010


Cyril Brulebois <kibi at debian.org> (13/11/2010):
> > +extern WindowPtr XYToWindow(SpritePtr pSprite, int x, int y);
>    ^^^^^^           ^^^^^^^^^^
>        Collateral damage?

Apparently, that was intended, since it's used in a later commit
(“Input: Add initial multitouch support from Xi 2.1”), just not
documented in that commit, nor completely done.

> Removing the quoted line fixes it.

Instead, the fix would rather be removing the following lines from
dix/events.c in the same commit:
| -static WindowPtr XYToWindow(
| -    SpritePtr pSprite,
| -    int x,
| -    int y
| -);
| -

as well as removing the “static” keyword in front of the function
definition (in the same file)..

so that XYToWindow() is no longer static, for real. That seems to
allow building with patches getting applied one by one (except for
the <stdint.h> include issue I mentioned in another mail).

Mraw,
KiBi.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101113/48be752f/attachment.pgp>


More information about the xorg-devel mailing list