[PATCH] xfree86: Initialize Pointer and Keyboard.

Peter Hutterer peter.hutterer at who-t.net
Sun Nov 14 13:44:22 PST 2010


On Sat, Nov 13, 2010 at 02:05:16AM +0100, Cyril Brulebois wrote:
> That helps us get rid of:
> |   CC     xf86Config.lo
> | xf86Config.c: In function ‘T.174’:
> | xf86Config.c:1228: warning: ‘Pointer$module’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$module’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$drv’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$drv’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$type_name’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$type_name’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$private’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$private’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$dev’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$dev’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$fd’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$fd’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$set_device_valuators’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$set_device_valuators’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$switch_mode’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$switch_mode’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$control_proc’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$control_proc’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$read_input’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$read_input’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$device_control’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$device_control’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$flags’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$flags’ was declared here
> | xf86Config.c:1228: warning: ‘Pointer$next’ may be used uninitialized in this function
> | xf86Config.c:1097: note: ‘Pointer$next’ was declared here
> 
> Signed-off-by: Cyril Brulebois <kibi at debian.org>
> ---
>  hw/xfree86/common/xf86Config.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
> index a9e827e..5800700 100644
> --- a/hw/xfree86/common/xf86Config.c
> +++ b/hw/xfree86/common/xf86Config.c
> @@ -1094,7 +1094,7 @@ checkCoreInputDevices(serverLayoutPtr servlayoutp, Bool implicitLayout)
>      const char *pointerMsg = NULL, *keyboardMsg = NULL;
>      InputInfoPtr *devs, /* iterator */
>              indp;
> -    InputInfoRec Pointer, Keyboard;
> +    InputInfoRec Pointer = {}, Keyboard = {};
>      XF86ConfInputPtr confInput;
>      XF86ConfInputRec defPtr, defKbd;
>      int count = 0;
> -- 
> 1.7.2.3

applied, thanks.

Cheers,
  Peter


More information about the xorg-devel mailing list