[PATCH] Build libxf86config with -fPIC.

Peter Hutterer peter.hutterer at who-t.net
Sun Nov 14 19:04:00 PST 2010


On Mon, Nov 15, 2010 at 10:29:30AM +0800, Keith Packard wrote:
> On Mon, 15 Nov 2010 11:25:11 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > From: Adam Jackson <ajax at redhat.com>
> > 
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> >  hw/xfree86/parser/Makefile.am |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/hw/xfree86/parser/Makefile.am b/hw/xfree86/parser/Makefile.am
> > index caf7079..3bda51e 100644
> > --- a/hw/xfree86/parser/Makefile.am
> > +++ b/hw/xfree86/parser/Makefile.am
> > @@ -32,7 +32,7 @@ libxf86config_internal_la_SOURCES = \
> >  
> >  libxf86config_a_SOURCES = \
> >  	$(INTERNAL_SOURCES)
> > -libxf86config_a_CFLAGS = $(AM_CFLAGS)
> > +libxf86config_a_CFLAGS = $(AM_CFLAGS) -fPIC
> 
> Should this change also be done for the two libfbcmap libraries in vfb
> and xnest?

I think the motivation here was that some other package we use in Fedora
links libxf86config into a shared library (I might be wrong here). AFAIK,
Debian doesn't package it at all. Not sure about other distros.

We've been carrying this patch since 1.4-ish, dropped it at some point when
it went .so for a short while and then added the patch again. We don't carry
anything for libfbcmap.

Cheers,
  Peter


More information about the xorg-devel mailing list