[PATCH] fix xserver segfaulting in glxext.c:DrawableGone() (NULL pointer)

[Thierry Vignaud]

On 17 November 2010 13:57, Julien Cristau <jcristau at debian.org> wrote:
>> I've attached a patch[1] against bug #31538 [2] that fix xserver segfaulting in
>> glxext.c:DrawableGone() on NULL pointer.
>> See stack trace there[3].
>>
>> It's against xserver-1.7.
>> xserver-1.9 doesn't trigger it anymore but I think it may still be relevant.
>>
> That patch looks like perl, not C.

ahem...

--- glx/glxext.c.tv     2010-11-11 04:19:15.000000000 +0100
+++ glx/glxext.c        2010-11-11 04:20:03.000000000 +0100
@@ -125,6 +125,8 @@
 static Bool DrawableGone(__GLXdrawable *glxPriv, XID xid)
 {
     __GLXcontext *c;
+   if (!glxPriv)
+       return;

     for (c = glxAllContexts; c; c = c->next) {
        if (c->isCurrent && (c->drawPriv == glxPriv || c->readPriv ==
glxPriv)) {