[PATCH xserver 6/8] xmlrules.in: specify the xserver entities depedencies on the target

[Gaetan Nadon]

On Thu, 2010-11-18 at 16:44 -0800, Alan Coopersmith wrote:

> > +%.pdf: %.xml $(XML_ENT_DIR)/xserver.ent

The generated files depend on xserver.ent which is what pattern rules
allow you to do.
This is not possible with the ".xml.html:" suffix rules.

> >       $(AM_V_GEN)$(XMLTO) $(XMLTO_FLAGS) --with-fop pdf $<
> >  endif
> >  
> > @@ -66,8 +66,3 @@ endif HAVE_XMLTO
> >  
> >  CLEAN_DOC_FILES = $(TXT_FILES) $(HTML_FILES) $(PDF_FILES)
> >  
> > -# All the files we build depend on the entities
> > -$(BUILT_DOC_FILES): $(XML_ENT_DIR)/xserver.ent

This target worked but is no longer needed due to pattern rules above.

> > -
> > -$(XML_ENT_DIR)/xserver.ent:
> > -     (cd $(XML_ENT_DIR) && $(MAKE) $(AM_MAKEFLAGS) $(@F))

My current level of understanding says it is impossible for this target
to ever work,
under any circumstances, even when invoked manually. It would have to be
a PHONEY target.

> 
> I don't see what this buys you, but it seems to lose the building
> of xserver.ent when needed.   (Though since it's built by configure
> I guess it shouldn't be needed except in unusual circumstances.)
> 

With the patches, I could not find a scenario where the docs did not get
rebuilt when
xserver.ent changes (due to autoreconf).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101119/5ad5ef40/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101119/5ad5ef40/attachment.pgp>