[PATCH xserver] xfree86: Don't install module .la files. (#4898)

Gaetan Nadon memsize at videotron.ca
Sun Nov 21 06:00:29 PST 2010


On Sun, 2010-11-21 at 00:05 -0800, Jesse Adkins wrote:

> > What I should have been suggesting is to use $(AM_V_at) as it is
> used in
> > several places in the server already.
> >
> > hw/xfree86/Makefile.in:       $(AM_V_at)rm -f Xorg && $(MAKE) Xorg
> >
> Should this fix be applied to the other driver patches as well? It

Yes

> seems like a v2 for this patch set is probably going to be needed at
> some point. The commit message is cryptic,

The sentence Matt wrote would be sufficient to inform future
generations.

>  the input drivers don't use
> moduledir, and some drivers install multiple .so files.
> 
> I certainly wouldn't mind, since most of the work could be easily
> automated. 

I thought so, that's why I provided my feedback as early as possible, at
the cost
of being a bit disorganized. I am done reviewing, I can't think of
anything else.

> Even if it were not, I'd like to make sure that this is
> 100% complete so this bug can be closed for good.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101121/ea5baa06/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101121/ea5baa06/attachment.pgp>


More information about the xorg-devel mailing list