[PATCH:libfontenc] Fail configure if zlib.h & -lz not found

Dan Nicholson dbn.lists at gmail.com
Mon Nov 22 05:47:55 PST 2010


On Sun, Nov 21, 2010 at 6:28 PM, Alan Coopersmith
<alan.coopersmith at oracle.com> wrote:
> Dan Nicholson wrote:
>> On Sun, Nov 21, 2010 at 2:59 PM, Rémi Cardona <remi at gentoo.org> wrote:
>>> Le 20/11/2010 07:04, Alan Coopersmith a écrit :
>>>>  # zlib
>>>> -
>>>> -AC_CHECK_LIB(z, gzclose)
>>>> +AC_CHECK_HEADER([zlib.h], [],
>>>> +                AC_MSG_FAILURE([zlib.h is required to compile libfontenc]))
>>>> +AC_CHECK_LIB(z, gzclose, [],
>>>> +             AC_MSG_FAILURE([zlib is required to compile libfontenc]))
>>> Any chance we could start using pkg-config to pick up zlib
>>> libs/includes? If memory serves, the .pc file was included upstream 2 or
>>> 3 years ago.
>>
>> Yeah, looks like it's been there since 2006 in the 1.2.3.1 release.
>>
>> http://zlib.net/ChangeLog.txt
>
> I guess that's why I'd never noticed it, since we're still shipping 1.2.3.
> I'll poke our maintainers to update, and won't object if someone on a system
> that has the .pc file wants to work on that change for the next release.

Weird, Fedora 13 is still shipping 1.2.3, too. It's probably safest to
have the fallback for random old hosts anyway. Something like:

PKG_CHECK_MODULES([ZLIB], [zlib], [],
    [AC_CHECK_HEADERS([zlib.h], [],
        [AC_MSG_FAILURE([zlib.h is required to compile libfontenc])])
    AC_CHECK_LIB(z, gzclose, [ZLIB_LIBS="-lz"],
        [AC_MSG_FAILURE([zlib.h is required to compile libfontenc])])])

--
Dan


More information about the xorg-devel mailing list