[PATCH 07/13] dix: reshuffle WindowOptRec to fill a hole on LP64

[Peter Harris]

On 2010-11-23 20:10, Matt Turner wrote:
> Probably just me not spotting the obvious, but I see
> 
> xserver $ git grep 'VisualID' | grep typedef
> hw/dmx/dmxclient.h:typedef unsigned long VisualID64;
> hw/xnest/Xnest.h:typedef unsigned long VisualID64;
> 
> So if CursorPtr is a pointer, it seems like VisualID will always be
> the same size as CursorPtr. I guess they'd be different for ABIs like
> MIPS/n32. I don't guess it hurts either way, as I don't know any
> systems where sizeof(pointer) < sizeof(long).
> 
> Maybe I'm not finding the correct definition of VisualID?

You appear to have found VisualID64, which isn't used by the core as far
as I can see.

VisualID is #defined to CARD32 in Xproto.h (from proto/x11proto.git).

Peter Harris
-- 
               Open Text Connectivity Solutions Group
Peter Harris                    http://connectivity.opentext.com/
Research and Development        Phone: +1 905 762 6001
pharris at opentext.com            Toll Free: 1 877 359 4866