[PATCH] include: let BitIsOn() return a boolean value.

walter harms wharms at bfs.de
Wed Nov 24 08:30:00 PST 2010



Am 24.11.2010 07:25, schrieb Keith Packard:
> On Wed, 24 Nov 2010 14:40:11 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> 
>> -#define BitIsOn(ptr, bit) (((BYTE *) (ptr))[(bit)>>3] & (1 << ((bit) & 7)))
>> +#define BitIsOn(ptr, bit) !!(((BYTE *) (ptr))[(bit)>>3] & (1 << ((bit) & 7)))
> 

bit is checked to be less than 8 with "(bit) & 7" but only in the second statement.
the linux kernel specifies them as inline code. maybe this is the way to go here also.

re,
 wh



More information about the xorg-devel mailing list