[PATCH 0/7] Xserver-spec: another batch of updates

Alan Coopersmith alan.coopersmith at oracle.com
Mon Nov 29 14:51:16 PST 2010


Jeremy Huddleston wrote:
> Series:
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 
> Does the documentation include reference for these from inputstr.h which I recall being added in the past year or two:
> 
> #define BitIsOn(ptr, bit) (!!(((BYTE *) (ptr))[(bit)>>3] & (1 << ((bit) & 7))))
> #define SetBit(ptr, bit)  (((BYTE *) (ptr))[(bit)>>3] |= (1 << ((bit) & 7)))
> #define ClearBit(ptr, bit) (((BYTE *)(ptr))[(bit)>>3] &= ~(1 << ((bit) & 7)))
> extern _X_EXPORT int CountBits(const uint8_t *mask, int len);

Not yet.  But as the inputstr.h header has lots of doxygen comments already,
perhaps some should just be added for those?

I have been wondering if the API reference material in the server should
move to just being generated from doxygen, and make the docbook docs be
more introduction/tutorial/overview type material.

Xserver-spec is certainly written for a different era - when people had to
port os & ddx layers to their platform, instead of a common POSIXish os layer
for pretty much all OS'es, and shared ddx layers with drivers at another
level beneath.   But a complete rewrite is a large task, so I've been plucking
at the low-hanging fruit first.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list