[PATCH] dix: do not use bit-wise operators on the boolean result of BitIsOn

Keith Packard keithp at keithp.com
Tue Nov 30 13:26:58 PST 2010


On Tue, 30 Nov 2010 19:06:55 +0100, Ferry Huberts <mailings at hupie.com> wrote:
> From: Ferry Huberts <ferry.huberts at pelagic.nl>
> 
> Performing bit-wise operations on a boolean amounts to mixing types,
> is confusing and basically incorrect; one should only perform
> logical operations on booleans.
> 
> Performing such operations relies on the implementation detail
> that a boolean is in fact an integer and that its value FALSE
> is implemented as zero.
> 
> Signed-off-by: Ferry Huberts <ferry.huberts at pelagic.nl>

Merged.
   5f34853..b169649  master -> master

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101130/81ddf052/attachment.pgp>


More information about the xorg-devel mailing list