[PATCH ati] Remove reference to pixmapPrivate.

Trevor Woerner twoerner at gmail.com
Fri Oct 1 10:14:51 PDT 2010


2010/10/1 Julien Cristau <jcristau at debian.org>:
> On Fri, Oct  1, 2010 at 18:29:54 +0200, Michel Dänzer wrote:
>
>> On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote:
>> > #if ABI_VIDEODRV_VERSION < SET_ABI_VERSION(9, 0)
>> > old code
>> > #else
>> > new code
>> > #endif
>>
>> That would work perfectly, if the ABI was bumped by every change which
>> breaks the ABI...
>>
> It'll work for this specific bump.  Or you could do something like
> AC_CHECK_MEMBERS([ScrnInfoRec.pixmapPrivate],[],[],[#include <xf86str.h>])
> in configure.ac, and check HAVE_SCRNINFOREC_PIXMAPPRIVATE.

Irregardless of which solution is chosen, if someone wanted to compile
a driver for an older server, they'd still have to checkout an older
version of the server code to compile against. Wouldn't they? What are
the chances a newer driver 1 year from now will still compile against
the older server source?

Shouldn't a check like this be done at runtime? By making a decision
like this at build time, aren't we sentencing the compiled driver to
always only connect to either older or newer servers, but not both?


More information about the xorg-devel mailing list