[PATCH xf86-input-vmmouse 1/2] Deprecated code cleanup.

Thomas Hellstrom thellstrom at vmware.com
Tue Oct 19 06:00:30 PDT 2010


On 10/19/2010 02:50 PM, Trevor Woerner wrote:
> On Tue, Oct 19, 2010 at 2:26 AM, Thomas Hellstrom
> <thellstrom at shipmail.org>  wrote:
>    
>> On 10/19/2010 01:14 AM, Peter Hutterer wrote:
>> Nak in its current form.
>>
>> (please see how this was done in one of the latest commits of
>> xf86-video-vmware).
>>      
> Yes I see, commit dfb062e024dfd20789ee8d43c7f94640faa5ea9f
>    

Yes, that's correct. Instead of defining a HAVE_XORG_SERVER_1_5_0 flag 
at configure time, IMO it's also OK to define such a flag during compile 
time using the macros XORG_VERSION_CURRENT and XORG_VERSION_NUMERIC

>    
>> If you want to respin the patch, please let me know. Otherwise I could do
>> that.
>>      
> If it's okay, I'd like the opportunity to fix my own issue, then I'll
> know how to do the rest of the code in drivers/.
>    

Please go ahead. Note that not all drivers care about this, but VMware 
uses this source for it's guest tools and it therefore needs to build 
also for these old servers.
Please post again for review before pushing.

Thanks,
/Thomas



More information about the xorg-devel mailing list