[PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

Dave Airlie airlied at gmail.com
Tue Oct 19 15:17:13 PDT 2010


On Mon, Oct 18, 2010 at 2:58 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
> This change does not solve the problem it claims to solve because it
> makes two assumptions about the driver that are not always true:
>
> 1. that it sends rendering requests to the GPU immediately, which can
>   kill performance on some GPUs, and
> 2. that the GPU processes all requests from multiple clients in order,
>   which is false for some GPUs.
>
> All a Damage event tells you is that your next X request will be
> procesed after the damage has landed, not that the damage has already
> landed or even that the rendering commands that cause the damage have
> been submitted to the GPU.
>
> In addition to the above, this commit also broke the Compiz
> "Wallpaper" plugin.
>
> This reverts commit 8d7b7a0d71e0b89321b3341b781bc8845386def6.

Reviewed-by: Dave Airlie <airlied at redhat.com>

I'm acking this as it causes a known regression with compiz on radeon,
and regressions are bad, I also agree with Aaron its a bad idea on
real GPUs.

Dave.


More information about the xorg-devel mailing list