[PATCH] Revert "Set DamageSetReportAfterOp to true for the damage extension" (#30260)

Kristian Høgsberg krh at bitplanet.net
Wed Oct 20 18:27:47 PDT 2010


On Wed, Oct 20, 2010 at 7:45 PM, Keith Packard <keithp at keithp.com> wrote:
> On Sun, 17 Oct 2010 09:58:50 -0700, Aaron Plattner <aplattner at nvidia.com> wrote:
>
>> In addition to the above, this commit also broke the Compiz
>> "Wallpaper" plugin.
>
> Ok, as usual, Dave Airlie is right here -- independent of whether this
> patch is a good idea (and I think it is), it should be reverted until it
> doesn't cause a regression.

Yup, and that's why I acked it in the first place.  It doesn't reduce
GPU/CPU parallelism and it's not new semantics for the damage
extension.  If the post-op reporting worked correctly, the only
difference would be in the case where a damage event overflows the
clients protocol buffer.  And in that case, the only difference would
be that the driver gets to see the rendering request before X flushes
the buffer.  There's really nothing to discuss.

Kristian


More information about the xorg-devel mailing list