[PATCH modular] Allow --cmd option to accept 'gmake'.

Gaetan Nadon memsize at videotron.ca
Fri Oct 22 12:47:44 PDT 2010


On Fri, 2010-10-22 at 14:07 -0400, Trevor Woerner wrote:

> From: Trevor Woerner <twoerner at gmail.com>
> 
> For those using 'gmake' instead of 'make'.
> 
> Signed-off-by: Trevor Woerner <twoerner at gmail.com>
> 


Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

Suggestion for a follow-on patch.
There is an assumption that make, git and now gmake are present on the system.
This is not always the case. This is what I get when running 'gmake':

        util/modular/build.sh: 1152: gmake: not found
        [...]
        ***** gmake failed on util/macros
        error processing module/component:  "util/macros"


And this is what I get when running 'bogus':

        $ util/modular/build.sh -o util/macros --cmd bogus /home/nadon/xorg/src
        The script can only process 'make', 'gmake', or 'git' commands
        It can't process 'bogus' commands

Just thinking out loud here, maybe we should accept any command, so as
long as it exists.
Checking `which some_cmd` should be enough. This allows user to run any
script they want.
I haven't thought it through.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101022/6f6076ff/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20101022/6f6076ff/attachment.pgp>


More information about the xorg-devel mailing list