[PATCH] mi: Integer overflow for dashed lines longer than 46340. #31093

[Siddhesh Poyarekar]

On Tue, Oct 26, 2010 at 1:07 AM, Keith Packard <keithp at keithp.com> wrote:
> On Mon, 25 Oct 2010 11:51:46 +0530, Siddhesh Poyarekar <siddhesh.poyarekar at gmail.com> wrote:
>
>> -    if (slopes[j].dy * slopes[i].dx > slopes[i].dy * slopes[j].dx)
>> +    if ((long long)slopes[j].dy * slopes[i].dx > (long long)slopes[i].dy * slopes[j].dx)
>
> Looks like the fix is in the right place, but I'd prefer int64_t instead of 'long long' here.
>

Thanks for the review. I have sent a modified patch.


-- 
Siddhesh Poyarekar
http://siddhesh.in