[PATCH 5/9] loader: warning fix

Mark Kettenis mark.kettenis at xs4all.nl
Sun Oct 31 08:05:08 PDT 2010


> From: Adam Jackson <ajax at redhat.com>
> Date: Tue, 19 Oct 2010 11:59:20 -0400
> 
> loadmod.c: In function ‘FreeSubdirs’:
> loadmod.c:377: warning: passing argument 1 of ‘free’ discards qualifiers
> from pointer target type
> /usr/include/stdlib.h:488: note: expected ‘void *’ but argument is of
> type ‘const char *’

This strongly suggest that the argument to FreeSubdirs() shouldn't
have been const in the first place.

> diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
> index 6e65227..d799432 100644
> --- a/hw/xfree86/loader/loadmod.c
> +++ b/hw/xfree86/loader/loadmod.c
> @@ -374,7 +374,7 @@ FreeSubdirs(const char **subdirs)
>  
>      if (subdirs) {
>  	for (s = subdirs; *s; s++)
> -	    free(*s);
> +	    free((char *)*s);
>  	free(subdirs);
>      }
>  }


More information about the xorg-devel mailing list