[PATCH 2/6] mi: change GE extension name to something painless for registry parsing

Peter Hutterer peter.hutterer at who-t.net
Tue Sep 7 15:33:02 PDT 2010


On Tue, Sep 07, 2010 at 08:17:21AM -0700, Aaron Plattner wrote:
> On Tue, Sep 07, 2010 at 05:50:23AM -0700, Tiago Vignatti wrote:
> > in the next commit this changes will makes more sense.
> > 
> > Signed-off-by: Tiago Vignatti <tiago.vignatti at nokia.com>
> > ---
> >  mi/miinitext.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/mi/miinitext.c b/mi/miinitext.c
> > index a7441c9..179cb9f 100644
> > --- a/mi/miinitext.c
> > +++ b/mi/miinitext.c
> > @@ -477,7 +477,7 @@ InitExtensions(int argc, char *argv[])
> >  #else /* XFree86LOADER */
> >  /* List of built-in (statically linked) extensions */
> >  static ExtensionModule staticExtensions[] = {
> > -    { GEExtensionInit, "Generic Event Extension", &noGEExtension, NULL, NULL},
> > +    { GEExtensionInit, "GenericEventExtension", &noGEExtension, NULL, NULL},
> >      { ShapeExtensionInit, "SHAPE", NULL, NULL, NULL },
> >  #ifdef MITSHM
> >      { ShmExtensionInit, SHMNAME, &noMITShmExtension, NULL, NULL },
> > -- 
> > 1.7.1.226.g770c5
> 
> Won't this break the library?
> 
> ge.h:#define GE_NAME         "Generic Event Extension"
> 
> That extension name is already in the wild.

yeah, I agree with Aaron here. for better or worse, this name is set in
stone.

Cheers,
  Peter


More information about the xorg-devel mailing list