[PATCH v2 2/5] dix: Enable client ID tracking in server.

[Fernando Carrijo]

Hi Rami,

I have a nitpick below.

Rami Ylimäki <rami.ylimaki at vincit.fi> wrote:

> Let X server to keep track of client PIDs and process names. Also make
> the client tracking interface available for external modules. Linking
> order of Xnest libraries needs to be fixed, because libmain depends on
> libdix and not vice versa.
> 
> Signed-off-by: Rami Ylimäki <rami.ylimaki at vincit.fi>
> ---
>  configure.ac                 |   12 +++++++++++-
>  dix/Makefile.am              |    5 ++++-
>  dix/main.c                   |    7 +++++++
>  hw/xfree86/loader/sdksyms.sh |    3 +++
>  include/Makefile.am          |    1 +
>  5 files changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 1a1f2d3..586df80 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -999,6 +999,16 @@ if test "x$RES" = xyes; then
>  	REQUIRED_MODULES="$REQUIRED_MODULES $RESOURCEPROTO"
>  fi
>  
> +AC_MSG_CHECKING([whether to track client ids])
> +if test "x$RES" = xyes -o "x$XSELINUX" = xyes; then

According to the autoconf manual [0]:

  The -a, -o, ‘(’, and ‘)’ operands [of test] are not present in all
  implementations, and have been marked obsolete by Posix 2008 [...]
  Thus, portable uses of test should [...] use shell constructs like
  ‘&&’ and ‘||’ instead.

[0] http://www.gnu.org/software/autoconf/manual/html_node/Limitations-of-Builtins.html#Limitations-of-Builtins