[PATCH] Use '[]' over 'test' throughout.

[Trevor Woerner]

On Tue, Sep 14, 2010 at 5:17 PM, Jeremy Huddleston <jeremyhu at apple.com> wrote:
>> -if test -z "$LISTONLY" ; then
>> +if [ -z "$LISTONLY" ]; then
>
> So if we're going to use -z here, why are we using x"$SOMETHING" = x elsewhere ?

Thanks for the feedback.

I wrote the "[ -z "$LISTONLY" ]" bit since that's the way I would
normally perform such a test, the others were existing tests written
by others.

If I said this patch was just to change all the "test"'s to "[]"'s
then I didn't think it would be proper to perform other modifications
to the code in addition to the one, stated change.

I'll prepare another patch to address your comments.