[PATCH modular] Remove addconfigh script.

Alan Coopersmith alan.coopersmith at oracle.com
Tue Sep 21 07:44:15 PDT 2010


Dan Nicholson wrote:
> On Sun, Sep 19, 2010 at 9:49 AM, Jesse Adkins <jesserayadkins at gmail.com> wrote:
>> This was added in 2005 as part of a big-ish commit. Since then, it hasn't been updated.
>>
>> This script isn't used by anything else in modular, and no real reason was given for it in
>> the commit (the commit only mentions it being added).
>>
>> Signed-off-by: Jesse Adkins <jesserayadkins at gmail.com>
> 
> Clearly it's for adding '#include <config.h>' to packages to support
> autoheader. It seems like a useful script to throw away even if it's
> unlikely to be used much. In fact, I really wish I'd known this
> existed when I was autotooling XTS. I ended up writing my own script
> with sed to do the same thing.

There's still a large body of code out there (like much of the old
ftp.x.org/contrib) written to use imake that may someday want to
convert to autotools that may find such a script useful - seems like
it's harmless to leave it there for them, though perhaps more useful
if we had a "imake -> autotools" conversion guide that pointed it out.


-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list