[PATCH] xfree86: fix VbeModeInfoBlock memcpy off-by-one (#30159)

Rémi Cardona remi at gentoo.org
Tue Sep 21 14:16:32 PDT 2010


Le 14/09/2010 09:39, Alexandre Rostovtsev a écrit :
> This patch fixes some old memcpy off-by-one errors in vbe.c that gcc-4.5
> complains about when compiling with -O1 or higher optimization:
> 
> In file included from /usr/include/string.h:642:0,
>                  from vbe.c:16:
> In function ‘memcpy’,
>     inlined from ‘VBEGetModeInfo’ at vbe.c:589:8:
> /usr/include/bits/string3.h:52:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer
> In function ‘memcpy’,
>     inlined from ‘VBEGetModeInfo’ at vbe.c:592:8:
> /usr/include/bits/string3.h:52:3: warning: call to __builtin___memcpy_chk will always overflow destination buffer
> 
> X.Org bug 30159 <https://bugs.freedesktop.org/show_bug.cgi?id=30159>

I'd put my S-O-B but I have no idea if this is the truly correct solution.

Could someone else take a look at this?

Cheers,

Rémi


More information about the xorg-devel mailing list