[PATCH xserver] config: remove --with-dri-driver-path option, use dri.pc #29740

[Gaetan Nadon]

On Wed, 2010-09-22 at 09:16 -0700, Jeremy Huddleston wrote:

> Just to be 100% complete here...  This has the effect that
> DRI_DRIVER_PATH="" rather than ${libdir}/dri on systems without dri.pc
> 
> Is that situation ok?  Should you check for existence of dri.pc first
> and set it to the old fallback if not present?
> 


I just check where used.


        ./glx/glxdriswrast.c:static const char dri_driver_path[] = DRI_DRIVER_PATH;
        ./glx/glxdri2.c:static const char dri_driver_path[] = DRI_DRIVER_PATH;
        ./glx/glxdri.c:static const char dri_driver_path[] = DRI_DRIVER_PATH;


Assuming this code is invoked if DRI is missing, it uses the full path
to load the driver.

        snprintf(filename, sizeof filename,
             "%s/%s_dri.so", dri_driver_path, driverName);
        
        screen->driver = dlopen(filename, RTLD_LAZY | RTLD_LOCAL);

I cannot be 100% sure that it won't uncover a dormant bug. If it does,
it will be in xorg
code (as opposed to a dependency) and is fixable.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100922/bd002556/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100922/bd002556/attachment.pgp>