[PATCH] randr: set error numbers of resource types in RRExtenstionInit() #30367

Keith Packard keithp at keithp.com
Wed Sep 29 12:53:34 PDT 2010


On Tue, 28 Sep 2010 18:44:53 +0200, Tobias Droste <tdroste at gmx.de> wrote:

> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=30367
> 
> Currently the ddx calls RROutputInit() before RRExtensionInit() is
> called. This causes RRErrorBase being 0 while setting resource type
> error (resource types RROutput, RRMode and RRCrtc).
> The fix moves the setting of error numbers to RRExtensionInit() to get
> the right RRErrorBase.

This is generating a few new warnings:

rrmode.c:283: warning: function declaration isn’t a prototype
rrmode.c: In function ‘RRModeInitErrorValue’:
rrmode.c:282: warning: old-style function definition
  CC     rroutput.lo
randr.c: In function ‘RRExtensionInit’:
randr.c:358: warning: implicit declaration of function ‘RRModeInitErrorValue’
randr.c:358: warning: nested extern declaration of ‘RRModeInitErrorValue’
randr.c:359: warning: implicit declaration of function ‘RRCrtcInitErrorValue’
randr.c:359: warning: nested extern declaration of ‘RRCrtcInitErrorValue’
randr.c:360: warning: implicit declaration of function ‘RROutputInitErrorValue’
randr.c:360: warning: nested extern declaration of ‘RROutputInitErrorValue’
rroutput.c:430: warning: function declaration isn’t a prototype
rroutput.c: In function ‘RROutputInitErrorValue’:
rroutput.c:429: warning: old-style function definition
rrcrtc.c:643: warning: function declaration isn’t a prototype
rrcrtc.c: In function ‘RRCrtcInitErrorValue’:
rrcrtc.c:642: warning: old-style function definition


-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100929/18b57164/attachment.pgp>


More information about the xorg-devel mailing list