libXext help with bug solution.

[Alistair Leslie-Hughes]

Hi Allan,

--------------------------------------------------
From: "Alan Coopersmith" <alan.coopersmith at oracle.com>
Sent: Tuesday, April 05, 2011 3:17 AM
To: "Alistair Leslie-Hughes" <leslie_alistair at hotmail.com>
Cc: <xorg-devel at lists.x.org>
Subject: Re: libXext help with bug solution.

> On 04/ 4/11 05:01 AM, Alistair Leslie-Hughes wrote:
>> Hi,
>>
>> While triaging bugs, I came across this one.
>>
>> https://bugs.freedesktop.org/show_bug.cgi?id=14723
>>
>> The basic issue is warnings during the compile.
>> The options
>> 1. Add prototypes (like the patch attached to the bug) to silence the 
>> warning.
>> 2. Remove the functions, since they appear to be unused.
>
> They're public API of libXext - we can't remove them without breaking
> compatibility, which we don't do in the client libraries, even for the
> cruftiest, most ancient extensions.
>
> (This is also why no new extensions should be added to libXext, so that
> we don't dig this hole any deeper.)
>
Thanks for the information.

Since the functions in question don't have function prototype in any header.

Would it be OK to defined the prototype in the source they are defined? Or
what header should they go into, since no more features are being add here?

Best Regards
 Alistair Leslie-Hughes