[RFC PATCH inputproto 0/3] Push 2.1 work into a branch

Daniel Stone daniel at fooishbar.org
Fri Apr 8 07:04:10 PDT 2011


Hi,

On Fri, Apr 08, 2011 at 02:28:10PM +1000, Peter Hutterer wrote:
> Chase pointed out that we don't have _any_ of the XI 2.1 stuff in the
> official repos yet. That makes testing harder for everyone and incremental
> review as well. This patchset is a simple one, just adding a few bumps and a
> warning to inputproto. I'm planning to push this to a inputproto-2.1-devel
> branch, so that at least we have one central repository for all the work.
> We can then release snapshots from that branch if we need them.
> 
> Note that this is _not_ on master, so normal users won't see the
> warning/error, only those building from that branch.
> 
> Any comments or suggestions?
> 
> Similar branches will have to be added to libXi and xserver.

I'm still going through all the mails from when I was off in
touchpadland now, so hopefully I will have come up with something soon.

But this sounds good to me.  It might be useful to have something like
the below too, so there's no way to claim they didn't know:
diff --git a/configure.ac b/configure.ac
index 39e4df9..2c87bba 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,5 +9,13 @@ m4_ifndef([XORG_MACROS_VERSION],
 XORG_MACROS_VERSION(1.3)
 XORG_DEFAULT_OPTIONS
 
+AC_ARG_ENABLE(unstable-protocol,
+              AS_HELP_STRING([--enable-unstable-protocol],
+                             [Enables compilation of yet-to-be-finalised protocol (default: disabled)]),
+              [UNSTABLE_PROTO=$enableval], [UNSTABLE_PROTO=no])
+if ! test "x$UNSTABLE_PROTO" = xyes; then
+    AC_MSG_ERROR([This branch contains protocol elements which have not yet been finalised.  When this branch is updated, you will probably need to recompile both the server, libXi, and input-using clients, and may experience crashes or undefined behaviour if you do not.])
+fi
+
 AC_OUTPUT([Makefile
            inputproto.pc])

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110408/bf5597f2/attachment.pgp>


More information about the xorg-devel mailing list